[release] Bump to version 45.1

- Mopidy favorites or monthly playlist adds should look at all scrobbles

PROJECT.org

@@ -414,10 +414,7 @@ placed in the media directory:
 And this should all be done in a celery task that is just kicked off by the
 "Export" button on the frontend
 
-** TODO [#B] Add importer class for IMAP imports :vrobbler:feature:imap:importers:project:personal:
-:PROPERTIES:
-:ID:       b1426d92-2feb-4d15-9738-d5b7b0594f96
-:END:
+
 ** TODO [#B] Add AllTrails as a source for Trail data :vrobbler:trails:feature:personal:project:
 :PROPERTIES:
 :ID:       39313362-cdfe-46e7-bbd4-9139a65c0b3c
@@ -489,7 +486,47 @@ whatever time KoReader reports, we need to know, given the date and the user
 profile's historic timezone, how many hours to adjust the KoReader time to get
 to GMT to save it in the database.
 
-** TODO [#B] Add ability to add mopidy tracks to Monthly playlists :feature:favorites:tracks:
+** TODO [#A] Make IMAP and WebDAV configurable :webdav:feature:imap:importers:
+:PROPERTIES:
+:ID:       b1426d92-2feb-4d15-9738-d5b7b0594f96
+:END:
+
+*** Description
+
+Currently we have webdav able to import post types of file-based incoming data,
+usually in the form of CSVs but also gpx files, bgstats json files, and
+audioscrobbler TSV files.
+
+What if the user could specify via their profile (settings) which imports they
+wanted to use IMAP for and which ones they wanted to use WebDAV for.
+
+Then we'd have two celery tasks that would be kicked off periodically via
+celerybeat, one for IMAP imports every 12 minutes and one for WebDAV every 3
+minutes. Both would be responsible for checking if a user has an configured
+imports of their type, check if an import needs to run, and dispatch the
+needed import celery task. This is how the WebDAV celery task currently works.
+
+This would also be an opporunity to clean up the code around WebDAV imports
+and make them more re-usable for other import services.
+
+* Version 45.1 [1/1]
+** DONE [#B] Mopidy favorites or monthly playlist adds should look at all scrobbles :bug:mopidy:favorites:tracks:
+:PROPERTIES:
+:ID:       0be7d11e-e268-2fd5-836a-e5b4d210e0fa
+:END:
+
+*** Description
+
+When favoriting a track and trying to add it to the Moidy favorite playlist, it
+sometimes happens that one scrobble did not come from Mopidy, but an earlier or
+later one did.
+
+Can we scan all the scrobbles of the track for a given user to see if any have
+`mopidy_uri` in the log and if so, use that to send along to Mopidy?
+
+
+* Version 45.0 [1/1]
+** DONE [#B] Add ability to add mopidy tracks to Monthly playlists :feature:favorites:tracks:
 :PROPERTIES:
 :ID:       c872ff0a-e71f-415f-b5a6-e62ea9634d14
 :END:
@@ -505,6 +542,7 @@ The patterns would be based on traditional Django date formatting patterns: http
 
 So "Y m F" would yield "2026 05 May" if the link is clicked in May of 2026.
 
+
 * Version 44.0 [1/1]
 ** DONE [#B] Add favorite feature for scrobbles :feature:favorites:scrobbles:
 :PROPERTIES:

justfile

@@ -15,9 +15,11 @@ celery:
 celery-beat:
     poetry run celery -A vrobbler beat -l info
 
-release kind="minor":
-    poetry run python scripts/release.py {{kind}}
-
 push:
     git push && git push gitea
     git push --tags && git push --tags gitea
+
+release kind="minor":
+    poetry run python scripts/release.py {{kind}}
+    @push
+    

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "vrobbler"
-version = "44.0"
+version = "45.1"
 description = ""
 authors = ["Colin Powell <colin@unbl.ink>"]
 

vrobbler/apps/profiles/forms.py

@@ -33,6 +33,7 @@ class UserProfileForm(forms.ModelForm):
             "ntfy_enabled",
             "mopidy_api_url",
             "favorites_mopidy_playlist",
+            "monthly_mopidy_playlist_pattern",
             "redirect_to_webpage",
             "enable_public_widgets",
             "widget_custom_css",

vrobbler/apps/profiles/migrations/0035_userprofile_monthly_mopidy_playlist_pattern.py

@@ -0,0 +1,23 @@
+# Generated by Django 4.2.30 on 2026-06-05 17:22
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("profiles", "0034_userprofile_favorites_mopidy_playlist"),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name="userprofile",
+            name="monthly_mopidy_playlist_pattern",
+            field=models.CharField(
+                blank=True,
+                help_text="Django date format pattern for monthly playlists (e.g. 'Y F')",
+                max_length=255,
+                null=True,
+            ),
+        ),
+    ]

vrobbler/apps/profiles/models.py

@@ -69,6 +69,10 @@ class UserProfile(TimeStampedModel):
         max_length=255, **BNULL,
         help_text="Playlist name (e.g. 'Favorites'). Will map to m3u:Favorites.m3u8",
     )
+    monthly_mopidy_playlist_pattern = models.CharField(
+        max_length=255, **BNULL,
+        help_text="Django date format pattern for monthly playlists (e.g. 'Y F')",
+    )
 
     redirect_to_webpage = models.BooleanField(default=True)
 

vrobbler/apps/scrobbles/tasks.py

@@ -576,3 +576,91 @@ def remove_favorite_from_mopidy_playlist(user_id, track_id):
         track=track,
     )
     remove_track_from_mopidy_favorites_playlist(proxy)
+
+
+@shared_task
+def add_scrobble_to_mopidy_queue(scrobble_id):
+    from scrobbles.models import Scrobble
+
+    scrobble = Scrobble.objects.filter(id=scrobble_id).first()
+    if not scrobble:
+        return
+
+    profile = scrobble.user.profile
+    mopidy_url = profile.mopidy_api_url
+    if not mopidy_url:
+        return
+
+    mopidy_uri = (scrobble.log or {}).get("raw_data", {}).get("mopidy_uri")
+    track = scrobble.track if scrobble.media_type == "Track" else None
+    if not mopidy_uri and track:
+        sibling = (
+            Scrobble.objects.filter(track=track, user=scrobble.user)
+            .order_by("-timestamp")
+            .iterator()
+        )
+        for s in sibling:
+            uri = (s.log or {}).get("raw_data", {}).get("mopidy_uri")
+            if uri:
+                mopidy_uri = uri
+                break
+
+    if not mopidy_uri:
+        logger.warning(
+            "No Mopidy URI found for scrobble",
+            extra={"scrobble_id": scrobble_id, "user_id": scrobble.user_id},
+        )
+        return
+
+    import requests
+
+    rpc_url = mopidy_url.rstrip("/") + "/rpc"
+    payload = {
+        "jsonrpc": "2.0",
+        "id": 1,
+        "method": "core.tracklist.add",
+        "params": {"uris": [mopidy_uri]},
+    }
+    try:
+        resp = requests.post(rpc_url, json=payload, timeout=10)
+        resp.raise_for_status()
+        rpc_result = resp.json()
+        if rpc_result.get("error"):
+            logger.error(
+                "Mopidy error adding to queue",
+                extra={"error": rpc_result["error"], "scrobble_id": scrobble_id},
+            )
+        else:
+            logger.info(
+                "Added track to Mopidy queue",
+                extra={"scrobble_id": scrobble_id, "mopidy_uri": mopidy_uri},
+            )
+    except requests.RequestException as e:
+        logger.error(
+            "Failed to add track to Mopidy queue",
+            extra={"scrobble_id": scrobble_id, "error": str(e)},
+        )
+
+
+@shared_task
+def add_scrobble_to_mopidy_monthly_playlist(scrobble_id):
+    from scrobbles.models import Scrobble
+    from scrobbles.utils import add_track_to_mopidy_monthly_playlist
+
+    scrobble = Scrobble.objects.filter(id=scrobble_id).first()
+    if not scrobble:
+        return
+
+    track = scrobble.track if scrobble.media_type == "Track" else None
+    if track:
+        sibling = (
+            Scrobble.objects.filter(track=track, user=scrobble.user)
+            .order_by("-timestamp")
+            .iterator()
+        )
+        for s in sibling:
+            if (s.log or {}).get("raw_data", {}).get("mopidy_uri"):
+                scrobble = s
+                break
+
+    add_track_to_mopidy_monthly_playlist(scrobble)

vrobbler/apps/scrobbles/urls.py

@@ -163,6 +163,11 @@ urlpatterns = [
         views.add_to_mopidy_queue,
         name="add-to-mopidy-queue",
     ),
+    path(
+        "scrobbles/<slug:uuid>/add-to-mopidy-monthly-playlist/",
+        views.add_to_mopidy_monthly_playlist,
+        name="add-to-mopidy-monthly-playlist",
+    ),
     path("scrobbles/<slug:uuid>/start/", views.scrobble_start, name="start"),
     path("scrobbles/<slug:uuid>/finish/", views.scrobble_finish, name="finish"),
     path("scrobbles/<slug:uuid>/cancel/", views.scrobble_cancel, name="cancel"),

vrobbler/apps/scrobbles/utils.py

@@ -15,6 +15,7 @@ from django.db import models
 from django.db.models.fields.json import KeyTextTransform
 from django.db.models.functions import Cast, TruncDate
 from django.utils import timezone
+from django.utils.dateformat import DateFormat
 from profiles.models import UserProfile
 from profiles.utils import now_user_timezone
 from scrobbles.constants import LONG_PLAY_MEDIA
@@ -467,9 +468,22 @@ def _ensure_mopidy_playlist(profile):
     return result
 
 
-def add_track_to_mopidy_favorites_playlist(favorite):
+def _scrobble_with_mopidy_uri(track, user):
+    """Find a scrobble for this track+user that has a mopidy_uri in its log."""
     from scrobbles.models import Scrobble
 
+    for scrobble in (
+        Scrobble.objects.filter(track=track, user=user)
+        .order_by("-timestamp")
+        .iterator()
+    ):
+        raw_data = scrobble.log.get("raw_data") or {}
+        if raw_data.get("mopidy_uri"):
+            return scrobble
+    return None
+
+
+def add_track_to_mopidy_favorites_playlist(favorite):
     if favorite.media_type != "Track" or not favorite.track:
         return
 
@@ -478,15 +492,7 @@ def add_track_to_mopidy_favorites_playlist(favorite):
         return
 
     track = favorite.track
-    scrobble = (
-        Scrobble.objects.filter(
-            track=track,
-            user=favorite.user,
-            log__raw_data__mopidy_uri__isnull=False,
-        )
-        .order_by("-timestamp")
-        .first()
-    )
+    scrobble = _scrobble_with_mopidy_uri(track, favorite.user)
 
     if not scrobble:
         logger.warning(
@@ -495,7 +501,7 @@ def add_track_to_mopidy_favorites_playlist(favorite):
         )
         return
 
-    mopidy_uri = scrobble.log["raw_data"]["mopidy_uri"]
+    mopidy_uri = (scrobble.log or {}).get("raw_data", {}).get("mopidy_uri")
 
     try:
         playlist = _ensure_mopidy_playlist(profile)
@@ -556,8 +562,6 @@ def resubmit_favorites_to_mopidy(user):
 
 
 def remove_track_from_mopidy_favorites_playlist(favorite):
-    from scrobbles.models import Scrobble
-
     if favorite.media_type != "Track" or not favorite.track:
         return
 
@@ -566,15 +570,7 @@ def remove_track_from_mopidy_favorites_playlist(favorite):
         return
 
     track = favorite.track
-    scrobble = (
-        Scrobble.objects.filter(
-            track=track,
-            user=favorite.user,
-            log__raw_data__mopidy_uri__isnull=False,
-        )
-        .order_by("-timestamp")
-        .first()
-    )
+    scrobble = _scrobble_with_mopidy_uri(track, favorite.user)
 
     if not scrobble:
         logger.warning(
@@ -583,7 +579,7 @@ def remove_track_from_mopidy_favorites_playlist(favorite):
         )
         return
 
-    mopidy_uri = scrobble.log["raw_data"]["mopidy_uri"]
+    mopidy_uri = (scrobble.log or {}).get("raw_data", {}).get("mopidy_uri")
 
     try:
         playlist = _ensure_mopidy_playlist(profile)
@@ -625,6 +621,90 @@ def remove_track_from_mopidy_favorites_playlist(favorite):
         )
 
 
+def _ensure_mopidy_playlist_by_name(profile, playlist_name):
+    """Find or create a Mopidy playlist by name (without m3u: prefix handling)."""
+    playlist_name = playlist_name.removeprefix("m3u:").removesuffix(".m3u8")
+    try:
+        playlists = _mopidy_rpc(profile, "core.playlists.as_list") or []
+        for pl in playlists:
+            if pl.get("name") == playlist_name:
+                existing = _mopidy_rpc(
+                    profile, "core.playlists.lookup", {"uri": pl["uri"]}
+                )
+                if existing:
+                    return existing
+    except (requests.RequestException, RuntimeError):
+        pass
+
+    result = _mopidy_rpc(
+        profile, "core.playlists.create",
+        {"name": playlist_name, "uri_scheme": "m3u"},
+    )
+    return result
+
+
+def add_track_to_mopidy_monthly_playlist(scrobble):
+    """Add a scrobbled track to a monthly Mopidy playlist based on the user's pattern."""
+    profile = scrobble.user.profile
+    pattern = profile.monthly_mopidy_playlist_pattern
+    if not pattern or not profile.mopidy_api_url:
+        return
+
+    mopidy_uri = (scrobble.log or {}).get("raw_data", {}).get("mopidy_uri")
+    if not mopidy_uri:
+        return
+
+    now = now_user_timezone(profile)
+    playlist_name = DateFormat(now).format(pattern)
+    if not playlist_name:
+        return
+
+    try:
+        playlist = _ensure_mopidy_playlist_by_name(profile, playlist_name)
+        if playlist and playlist.get("uri"):
+            existing_tracks = playlist.get("tracks") or []
+            track_uris = [t["uri"] for t in existing_tracks if isinstance(t, dict)]
+            if mopidy_uri in track_uris:
+                logger.info(
+                    "Track already in monthly Mopidy playlist",
+                    extra={"playlist": playlist_name, "mopidy_uri": mopidy_uri},
+                )
+                return
+
+            new_track = {"__model__": "Track", "uri": mopidy_uri}
+            existing_tracks.append(new_track)
+            _mopidy_rpc(
+                profile,
+                "core.playlists.save",
+                {
+                    "playlist": {
+                        "__model__": "Playlist",
+                        "uri": playlist["uri"],
+                        "name": playlist.get("name", playlist_name),
+                        "tracks": existing_tracks,
+                        "last_modified": playlist.get("last_modified"),
+                    },
+                },
+            )
+        else:
+            _mopidy_rpc(profile, "core.tracklist.add", {"uris": [mopidy_uri]})
+
+        logger.info(
+            "Added track to monthly Mopidy playlist",
+            extra={
+                "playlist": playlist_name,
+                "track_id": scrobble.media_obj.id,
+                "user_id": scrobble.user_id,
+            },
+        )
+    except (requests.RequestException, RuntimeError) as e:
+        logger.debug(e)
+        logger.error(
+            "Failed to add track to monthly Mopidy playlist",
+            extra={"playlist": playlist_name, "error": str(e)},
+        )
+
+
 def remove_last_part(url: str) -> str:
     url = url.rstrip("/")
     if "/" not in url:

vrobbler/apps/scrobbles/views.py

@@ -35,6 +35,7 @@ from django.http import (
 from django.shortcuts import get_object_or_404, redirect
 from django.urls import reverse_lazy
 from django.utils import timezone
+from django.utils.dateformat import DateFormat
 from django.views.decorators.csrf import csrf_exempt
 from django.views.decorators.http import require_POST
 from django.views.generic import DetailView, FormView, TemplateView
@@ -991,46 +992,42 @@ def add_to_mopidy_queue(request, uuid):
         )
         return redirect("scrobbles:detail", uuid=uuid)
 
-    raw_data = scrobble.log.get("raw_data", {})
-    mopidy_uri = raw_data.get("mopidy_uri")
-    logger.debug(mopidy_uri)
+    from scrobbles.tasks import add_scrobble_to_mopidy_queue as task
 
-    if not mopidy_uri:
+    task.delay(scrobble.id)
+    msg = f'Adding "{scrobble.media_obj}" to Mopidy queue.'
+    messages.add_message(request, messages.SUCCESS, msg)
+    return redirect("scrobbles:detail", uuid=uuid)
+
+
+@require_POST
+def add_to_mopidy_monthly_playlist(request, uuid):
+    if not request.user.is_authenticated:
+        return redirect("scrobbles:detail", uuid=uuid)
+
+    scrobble = get_object_or_404(Scrobble, uuid=uuid, user=request.user)
+    profile = request.user.profile
+    pattern = profile.monthly_mopidy_playlist_pattern
+
+    if not pattern or not profile.mopidy_api_url:
         messages.add_message(
             request,
             messages.ERROR,
-            "No Mopidy URI found for this scrobble.",
+            "Monthly playlist pattern or Mopidy API URL not configured in your profile.",
         )
         return redirect("scrobbles:detail", uuid=uuid)
 
-    rpc_url = mopidy_url.rstrip("/") + "/rpc"
-    payload = {
-        "jsonrpc": "2.0",
-        "id": 1,
-        "method": "core.tracklist.add",
-        "params": {"uris": [mopidy_uri]},
-    }
+    now = now_user_timezone(profile)
+    playlist_name = DateFormat(now).format(pattern)
 
-    try:
-        resp = requests.post(rpc_url, json=payload, timeout=10)
-        resp.raise_for_status()
-        rpc_result = resp.json()
-        if rpc_result.get("error"):
-            messages.add_message(
-                request,
-                messages.ERROR,
-                f'Mopidy error: {rpc_result["error"]}',
-            )
-        else:
-            msg = f'Added "{scrobble.media_obj}" to Mopidy queue.'
-            messages.add_message(request, messages.SUCCESS, msg)
-    except requests.RequestException as e:
-        messages.add_message(
-            request,
-            messages.ERROR,
-            f"Failed to contact Mopidy: {e}",
-        )
+    from scrobbles.tasks import add_scrobble_to_mopidy_monthly_playlist as task
 
+    task.delay(scrobble.id)
+    messages.add_message(
+        request,
+        messages.SUCCESS,
+        f'Adding "{scrobble.media_obj}" to monthly playlist "{playlist_name}".',
+    )
     return redirect("scrobbles:detail", uuid=uuid)
 
 
@@ -1243,6 +1240,17 @@ class ScrobbleDetailView(DetailView):
                     user=self.request.user, **{fk_field: media_obj}
                 ).exists()
 
+        if media_type == "Track" and media_obj:
+            scrobbles = Scrobble.objects.filter(
+                track=media_obj, user=self.object.user
+            ).order_by("-timestamp")[:20]
+            context["has_mopidy_uri"] = any(
+                (s.log or {}).get("raw_data", {}).get("mopidy_uri")
+                for s in scrobbles
+            )
+        else:
+            context["has_mopidy_uri"] = False
+
         return context
 
 

vrobbler/templates/scrobbles/scrobble_detail.html

@@ -66,11 +66,17 @@
 <h2>{{ object.logdata.title }}</h2>
 {% endif %}
 <h3 class="text-muted">{{ object.local_timestamp }}</h3>
-{% if object.media_type == "Track" and object.log.raw_data.mopidy_uri and user.profile.mopidy_api_url %}
+{% if object.media_type == "Track" and has_mopidy_uri and user.profile.mopidy_api_url %}
 <form method="post" action="{% url 'scrobbles:add-to-mopidy-queue' object.uuid %}" class="mb-1">
   {% csrf_token %}
     <button type="submit" class="btn btn-sm btn-outline-secondary">add to mopidy queue</button>
 </form>
+{% if user.profile.monthly_mopidy_playlist_pattern %}
+<form method="post" action="{% url 'scrobbles:add-to-mopidy-monthly-playlist' object.uuid %}" class="mb-1">
+  {% csrf_token %}
+    <button type="submit" class="btn btn-sm btn-outline-secondary">add to monthly playlist</button>
+</form>
+{% endif %}
 {% endif %}
 {% if object.media_type == "Track" %}
 <p class="text-muted small">Source: {{ object.source }}{% if object.log.mopidy_source %} ({{ object.log.mopidy_source|capfirst }}){% endif %}</p>