[release] Bump to version 40.0

- Fix error in org-mode task sync
- Adjust how similar artists are shown

.gitea/workflows/deploy.yml

@@ -116,8 +116,8 @@ jobs:
             mkdir -p /var/lib/vrobbler
             echo "${{ gitea.sha }}" | cut -c1-8 > /var/lib/vrobbler/commit.txt
             pip uninstall -y vrobbler
-            rm -f /var/lib/vrobbler/dist/*.whl
-            pip install /var/lib/vrobbler/dist/*.whl
+            rm -f /var/lib/vrobbler/*.whl
+            pip install /var/lib/vrobbler/*.whl
             python -c "import vrobbler; print(f'vrobbler {vrobbler.__version__} installed OK')"
             vrobbler migrate
             vrobbler collectstatic --noinput

PROJECT.org

@@ -93,7 +93,7 @@ fetching and simple saving.
 :LOGBOOK:
 CLOCK: [2025-07-09 Wed 09:55]--[2025-07-09 Wed 10:15] =>  0:20
 :END:
-* Backlog [-2/11] :vrobbler:project:personal:
+* Backlog [0/13] :vrobbler:project:personal:
 ** TODO [#C] Add sentiment parsing for Scrobbles with notes :vrobbler:project:scrobbles:sentiment:
 :PROPERTIES:
 :ID:       37781d6a-f3b0-48b2-bf98-33c2c791cf85
@@ -489,6 +489,56 @@ whatever time KoReader reports, we need to know, given the date and the user
 profile's historic timezone, how many hours to adjust the KoReader time to get
 to GMT to save it in the database.
 
+** TODO [#A] Orgmode tasks are not updated if in progress :tasks:orgmode:bug:
+:PROPERTIES:
+:ID:       7dcebb2c-7c4c-4ac5-bee6-c2e36c3811f9
+:END:
+
+*** Description
+
+Currently if you POST to the orgmode webhook with a task that's already in progress, the request just stops there.
+
+We should add logic where if the task is in-progress, instead of doing nothing,
+it checks the webhook payload against the in-progress tasks and updates the
+description of the scrobble.log with the incoming task description if it's
+different. And the same for comments. If a comment (by timestamp key) is
+different in the webhook than what's in the scrobble.log, update the comment in
+the scrobble.log
+
+* Version 40.0 [2/2]
+** DONE [#A] Fix error in org-mode task sync :emacs:orgmode:tasks:bug:
+:PROPERTIES:
+:ID:       03256d2a-48aa-4be7-aeb3-fa1cfddc86bf
+:END:
+ 
+*** Description
+#+begin_src python
+  File "/usr/local/lib/python3.11/site-packages/vrobbler/apps/tasks/webhooks.py", line 236, in post
+    emacs_scrobble_update_task(
+  File "/usr/local/lib/python3.11/site-packages/vrobbler/apps/scrobbles/scrobblers.py", line 844, in emacs_scrobble_update_task
+    for note in emacs_notes:
+TypeError: 'NoneType' object is not iterable
+#+end_src
+** DONE [#B] Adjust how similar artists are shown :feature:templates:artists:music:
+:PROPERTIES:
+:ID:       2a081620-a0a2-4851-a7cf-4043f9c2ee31
+:END:
+
+*** Description
+
+Currently we show the top 10 similar artists on the Artist detail page linked to
+the artist detail page on Vrobbler.
+
+First off, this is very slow. We should look into speeding up the rendering of
+the similar artists widget.
+
+Second, the artist name in the similar artist list should be a link to the
+Vrobbler artist detail page, but there should also be a [musicbrainz] link next
+to it, that links out to the musicbrainz page whether we have the artist in the
+Vrobbler database or not.
+
+
+
 * Version 39.3 [2/2]
 ** DONE [#A] Issue found when doing a release :bug:tooling:release:cicd:
 :PROPERTIES:
@@ -522,7 +572,7 @@ and once on tag push.
 We should do builds on each push and build and deploys only when a new tag is
 detected.
 
-
+        
 * Version 39.2 [2/2]
 ** DONE [#B] Releases do not pin commit to the repo for display :bug:tooling:releases:
 :PROPERTIES:

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "vrobbler"
-version = "39.3"
+version = "40.0"
 description = ""
 authors = ["Colin Powell <colin@unbl.ink>"]
 

vrobbler/apps/music/views.py

@@ -19,11 +19,7 @@ class ArtistListView(generic.ListView):
     paginate_by = 100
 
     def get_queryset(self):
-        qs = (
-            super()
-            .get_queryset()
-            .annotate(scrobble_count=Count("track__scrobble"))
-        )
+        qs = super().get_queryset().annotate(scrobble_count=Count("track__scrobble"))
         genre = self.request.GET.get("genre")
         if genre:
             qs = qs.filter(theaudiodb_genre=genre)
@@ -82,26 +78,30 @@ class ArtistDetailView(generic.DetailView):
 
         similar = artist.similar_artists or []
         if similar:
-            mbids = [sa["artist_mbid"] for sa in similar if sa.get("artist_mbid")]
+            top = similar[:10]
+            mbids = [sa["artist_mbid"] for sa in top if sa.get("artist_mbid")]
             local_artists = {
                 a.musicbrainz_id: a
                 for a in Artist.objects.filter(musicbrainz_id__in=mbids)
             }
-            for sa in similar:
+            for sa in top:
                 local = local_artists.get(sa.get("artist_mbid"))
                 sa["local_url"] = local.get_absolute_url() if local else None
-            context_data["similar_artists"] = similar
+                sa["musicbrainz_url"] = (
+                    f"https://musicbrainz.org/artist/{sa['artist_mbid']}"
+                    if sa.get("artist_mbid")
+                    else None
+                )
+            context_data["similar_artists"] = top
 
         if artist.theaudiodb_genre:
-            context_data["genre_count"] = (
-                Artist.objects.filter(theaudiodb_genre=artist.theaudiodb_genre)
-                .count()
-            )
+            context_data["genre_count"] = Artist.objects.filter(
+                theaudiodb_genre=artist.theaudiodb_genre
+            ).count()
         if artist.theaudiodb_mood:
-            context_data["mood_count"] = (
-                Artist.objects.filter(theaudiodb_mood=artist.theaudiodb_mood)
-                .count()
-            )
+            context_data["mood_count"] = Artist.objects.filter(
+                theaudiodb_mood=artist.theaudiodb_mood
+            ).count()
 
         return context_data
 

vrobbler/apps/tasks/webhooks.py

@@ -235,7 +235,7 @@ class EmacsWebhookView(APIView):
         if task_in_progress:
             emacs_scrobble_update_task(
                 post_data.get("source_id"),
-                post_data.get("notes", []),
+                post_data.get("notes") or [],
                 user_id,
                 description=post_data.get("body"),
             )

vrobbler/templates/music/artist_detail.html

@@ -53,13 +53,15 @@
                 <tr>
                     <th scope="col">Artist</th>
                     <th scope="col">Score</th>
+                    <th scope="col"></th>
                 </tr>
             </thead>
             <tbody>
-                {% for sa in similar_artists|slice:":10" %}
+                {% for sa in similar_artists %}
                 <tr>
                     <td>{% if sa.local_url %}<a href="{{sa.local_url}}">{{sa.name}}</a>{% else %}{{sa.name}}{% endif %}</td>
                     <td>{{sa.score}}</td>
+                    <td>{% if sa.musicbrainz_url %}<a href="{{sa.musicbrainz_url}}">musicbrainz</a>{% endif %}</td>
                 </tr>
                 {% endfor %}
             </tbody>