[release] 23

PROJECT.org

@@ -79,7 +79,7 @@ fetching and simple saving.
 :LOGBOOK:
 CLOCK: [2025-07-09 Wed 09:55]--[2025-07-09 Wed 10:15] =>  0:20
 :END:
-* Backlog [1/22]
+* Backlog [3/23]
 ** TODO [#A] Add classmethod for metadata fetching to tracks :vrobbler:feature:music:personal:project:
 :PROPERTIES:
 :ID:       bc4b45e5-4c65-13c5-ab7b-1937d3fbf5c2
@@ -88,7 +88,6 @@ CLOCK: [2025-07-09 Wed 09:55]--[2025-07-09 Wed 10:15] =>  0:20
 CLOCK: [2025-07-09 Wed 10:15]
 :END:
 
-** TODO Look in comments for a timestamp for start from BG stats if the time is missing :vrobbler:feature:boardgames:project:personal:
 ** TODO Add importer class for IMAP imports :vrobbler:feature:imap:importers:project:personal:
 ** TODO Add youtube link in place of IMDB on video detail page :vrobbler:feature:videos:personal:project:
 ** TODO [#A] Tasks from org-mode should properly update notes and leave them out of the body :vrobbler:bug:tasks:
@@ -443,17 +442,27 @@ it's annoying.
 ** TODO [#C] Allow users to see tasks on calendar view :vrobbler:personal:project:templates:feature:
 https://codepen.io/oliviale/pen/QYqybo
 ** TODO [#C] Come up with a possible flow using WebDAV and super-productivity for tasks :personal:feature:project:vrobbler:tasks:
-* Version 19.0
+* Version 23.0 [3/3]
+** DONE Add dynamic forms for LogData classes :personal:feature:vrobbler:project:forms:logdata:
+:PROPERTIES:
+:ID:       0db889a1-f262-fba2-7fed-ed99eded1c88
+:END:
+** DONE Look in comments for a timestamp for start from BG stats if the time is missing :vrobbler:feature:boardgames:project:personal:
+** DONE Fix long play scrobbles to provide better data :vrobbler:feature:scrobbles:longplay:personal:project:
+:PROPERTIES:
+:ID:       99f6bd77-dc8f-6ed1-0321-32a52c944264
+:END:
+* Version 19.0 [1/1]
 ** DONE Add periodic check for mood :vrobbler:feature:moods:personal:project:
 :PROPERTIES:
 :ID:       55404488-c69f-0dd5-838e-1d1e15c873eb
 :END:
-* Version 18.7
+* Version 18.7 [1/1]
 ** DONE Use the timezone history log to fix old Scrobbles that fall into those timezone blocks :vrobbler:chore:scrobbles:project:personal:
 :PROPERTIES:
 :ID:       9d055ac1-584b-20c8-7ad9-9ce36b329dc7
 :END:
-* Version 18.4
+* Version 18.4 [2/2]
 ** DONE Track timezone changes for profiles :vrobbler:feature:profiles:personal:project:
 :PROPERTIES:
 :ID:       89ec867f-29fd-82f1-be17-b49dddc30c78
@@ -466,12 +475,12 @@ https://codepen.io/oliviale/pen/QYqybo
 - Note taken on [2025-07-20 Sun 16:21]
 
   This thing is kicking my butt. As it stands it works, but the scrobbles are not assigned to the tracks properly.
-* Version 18.3
+* Version 18.3 [1/1]
 ** DONE Add timezone awarness to IMAP importer :personal:project:vrobbler:feature:importer:imap:timezones:
 :PROPERTIES:
 :ID:       05837b7c-96aa-6190-3678-e2ae7c7cac75
 :END:
-* Version 18
+* Version 18 [4/4]
 ** DONE Condense tracks of the same title by the same artist with multiple albums :vrobbler:feature:music:project:personal:
 :PROPERTIES:
 :ID:       b39fcec8-59fd-eab0-5809-b8144c7d2708
@@ -592,7 +601,7 @@ https://codepen.io/oliviale/pen/QYqybo
 :PROPERTIES:
 :ID:       23f485e3-988c-6198-c79d-91fdf92f001c
 :END:
-* Version 17.0
+* Version 17.0 [6/6]
 ** DONE [#A] Fix bug in new task label lookup for Emacs/Org-mode :vrobbler:bug:tasks:
 :PROPERTIES:
 :ID:       683fb109-dfc4-85e4-80f0-ea618434f61e
@@ -655,7 +664,7 @@ Not sure if the problem is in my Emacs hook sending or Vrobbler itself.
 :PROPERTIES:
 :ID:       df58f8d0-fa4a-2037-c7d7-e5388c239042
 :END:
-* Version 0.16.0
+* Version 0.16.0 [19/19]
 ** DONE [#A] Jellyfin, bandcamp tracks from Mopidy create duplicate music tracks :bug:scrobbling:music:
 :PROPERTIES:
 :ID:       670e8634-49b5-dce9-1684-14f2ffb797f1
@@ -760,7 +769,7 @@ out using that.
 ** DONE Fix bug in Jellyfin scrobbles that spam more scrobbles after completion :scrobbling:videos:bug:
 This was fixed a while ago, but there's a new manifested bug. Going to create a
 separate bug tracking ticket for that.
-* Version 0.11.4
+* Version 0.11.4 [9/9]
 ** DONE Add rudimentary video game scrobbling :improvement:content:videogames:
 CLOSED: [2023-03-07 Tue 11:11]
 ** DONE Add ability to scrobble from KOReader statistics files :improvement:books:content:

tests/scrobbles_tests/test_metadata.py

@@ -1,6 +1,6 @@
 import pytest
 
-from scrobbles.dataclasses import BoardGameLogData, BoardGameScoreLogData
+#from scrobbles.dataclasses import BoardGameLogData, BoardGameScoreLogData
 
 
 @pytest.mark.skip("Need to get local tests running working again")

vrobbler/apps/boardgames/bgg.py

@@ -119,8 +119,6 @@ def push_scrobble_to_bgg(scrobble: "Scrobble", user: User) -> Optional[bool]:
             data=json.dumps(login_payload),
             headers=headers,
         )
-        print(p)
-
         players = []
         if scrobble.log:
             for player in scrobble.log.get("players"):
@@ -153,4 +151,3 @@ def push_scrobble_to_bgg(scrobble: "Scrobble", user: User) -> Optional[bool]:
             data=json.dumps(play_payload),
             headers=headers,
         )
-        print(r)

vrobbler/apps/boardgames/models.py

@@ -5,6 +5,7 @@ from datetime import datetime
 from typing import Optional
 from uuid import uuid4
 
+from django import forms
 import requests
 from boardgames.bgg import lookup_boardgame_from_bgg
 from django.conf import settings
@@ -79,9 +80,20 @@ class BoardGameLogData(BaseLogData, LongPlayLogData):
     board: Optional[str] = None
     rounds: Optional[int] = None
     details: Optional[str] = None
-    # Legacy
-    learning: Optional[bool] = None
-    scenario: Optional[str] = None
+
+    _excluded_fields = {
+        "lichess_id",
+        "speed",
+        "rated",
+        "moves",
+        "variant",
+    }
+
+    @cached_property
+    def location(self):
+        if not self.location_id:
+            return
+        return BoardGameLocation.objects.filter(id=self.location_id).first()
 
     @cached_property
     def player_log(self) -> str:
@@ -94,6 +106,23 @@ class BoardGameLogData(BaseLogData, LongPlayLogData):
             )
         return ""
 
+    @classmethod
+    def override_fields(cls) -> dict:
+        fields = {}
+        for base in cls.mro()[1:]:
+            if hasattr(base, "override_fields"):
+                base_fields = base.override_fields()
+                fields.update(base_fields)
+        custom_fields = {
+            "location_id": forms.ModelChoiceField(
+                queryset=BoardGameLocation.objects.all(),
+                required=False,
+                widget=forms.Select(),
+            )
+        }
+        fields.update(custom_fields)
+        return fields
+
 
 class BoardGamePublisher(TimeStampedModel):
     name = models.CharField(max_length=255)

vrobbler/apps/books/koreader.py

@@ -291,8 +291,6 @@ def build_scrobbles_from_book_map(
                 ) or stop_timestamp.dst() == timedelta(0):
                     timestamp = timestamp - timedelta(hours=1)
                     stop_timestamp = stop_timestamp - timedelta(hours=1)
-                else:
-                    print("In DST! ", timestamp)
 
                 scrobble = Scrobble.objects.filter(
                     timestamp=timestamp,

vrobbler/apps/books/models.py

@@ -1,7 +1,7 @@
 from collections import OrderedDict
 from dataclasses import dataclass
 import logging
-from datetime import timedelta, datetime
+from datetime import datetime
 from typing import Optional
 from uuid import uuid4
 
@@ -22,7 +22,6 @@ from scrobbles.mixins import (
     LongPlayScrobblableMixin,
     ObjectWithGenres,
     ScrobblableConstants,
-    ScrobblableMixin,
 )
 from scrobbles.utils import get_scrobbles_for_media
 from taggit.managers import TaggableManager
@@ -64,6 +63,16 @@ class BookLogData(BaseLogData, LongPlayLogData):
     page_start: Optional[int] = None
     page_end: Optional[int] = None
 
+    _excluded_fields = {"koreader_hash", "page_data"}
+
+    def avg_seconds_per_page(self):
+        if self.page_data:
+            total_duration = 0
+            for page_num, stats in self.page_data.items():
+                total_duration += stats.get("duration", 0)
+            if total_duration:
+                return int(total_duration / len(self.page_data))
+
 
 class Author(TimeStampedModel):
     name = models.CharField(max_length=255)

vrobbler/apps/bricksets/models.py

@@ -1,9 +1,11 @@
 from dataclasses import dataclass
+
 from django.db import models
 from django.urls import reverse
 from imagekit.models import ImageSpecField
 from imagekit.processors import ResizeToFit
 from scrobbles.mixins import LongPlayScrobblableMixin
+
 from vrobbler.apps.scrobbles.dataclasses import (
     BaseLogData,
     LongPlayLogData,

vrobbler/apps/music/models.py

@@ -1,5 +1,6 @@
 import logging
-from typing import Dict, Optional
+from dataclasses import dataclass
+from typing import Optional
 from uuid import uuid4
 
 import musicbrainzngs
@@ -15,24 +16,26 @@ from imagekit.processors import ResizeToFit
 from music.allmusic import get_allmusic_slug, scrape_data_from_allmusic
 from music.bandcamp import get_bandcamp_slug
 from music.musicbrainz import (
-    get_album_metadata,
     get_album_metadata_with_artist,
-    get_artist_metadata_extended,
     get_recording_mbid_exact,
     get_track_metadata_with_artist,
-    lookup_album_dict_from_mb,
-    lookup_album_from_mb,
-    lookup_track_from_mb,
-    lookup_artist_from_mb,
 )
 from music.theaudiodb import lookup_album_from_tadb, lookup_artist_from_tadb
 from music.utils import clean_artist_name
+from scrobbles.dataclasses import BaseLogData
 from scrobbles.mixins import ScrobblableConstants, ScrobblableMixin
 
 logger = logging.getLogger(__name__)
 BNULL = {"blank": True, "null": True}
 
 
+@dataclass
+class TrackLogData(BaseLogData):
+    mopidy_source: Optional[str] = None
+    rockbox_info: Optional[str] = None
+    rating: Optional[int] = None
+
+
 class Artist(TimeStampedModel):
     """Represents a music artist.
 
@@ -529,13 +532,15 @@ class Album(TimeStampedModel):
             logger.info(
                 f"Could not find album {name} with artist {artist.name} on musicbrainz"
             )
-            album, created = Album.objects.get_or_create(
-                name=name,
-            )
-            if created:
-                # album.fix_metadata()
-                # album.fetch_artwork()
-                ...
+            album = Album.objects.filter(name=name).first()
+            if not album:
+                album, created = Album.objects.get_or_create(
+                    name=name,
+                )
+                if created:
+                    # album.fix_metadata()
+                    # album.fetch_artwork()
+                    ...
             return album
 
         if not artist:
@@ -605,6 +610,9 @@ class Track(ScrobblableMixin):
     def __str__(self):
         return f"{self.title} by {self.artist}"
 
+    def logdata_cls(self):
+        return TrackLogData
+
     @property
     def primary_album(self):
         if self.album:

vrobbler/apps/music/utils.py

@@ -10,11 +10,11 @@ logger = logging.getLogger(__name__)
 def clean_artist_name(name: str) -> str:
     """Remove featured names from artist string."""
     if " feat. " in name.lower():
-        name = re.split("feat.", name, flags=re.IGNORECASE)[0].strip()
+        name = re.split(" feat. ", name, flags=re.IGNORECASE)[0].strip()
     if " w. " in name.lower():
-        name = re.split("feat.", name, flags=re.IGNORECASE)[0].strip()
+        name = re.split(" w. ", name, flags=re.IGNORECASE)[0].strip()
     if " featuring " in name.lower():
-        name = re.split("featuring", name, flags=re.IGNORECASE)[0].strip()
+        name = re.split(" featuring ", name, flags=re.IGNORECASE)[0].strip()
     # if " & " in name.lower() and "of the wand" not in name.lower():
     #    name = re.split("&", name, flags=re.IGNORECASE)[0].strip()
 

vrobbler/apps/people/models.py

@@ -15,3 +15,6 @@ class Person(TimeStampedModel):
     bgg_username = models.CharField(max_length=100, **BNULL)
     lichess_username = models.CharField(max_length=100, **BNULL)
     bio = models.TextField(**BNULL)
+
+    def __str__(self):
+        return self.name

vrobbler/apps/profiles/models.py

@@ -141,12 +141,10 @@ class UserProfile(TimeStampedModel):
 
     @cached_property
     def task_context_tags(self) -> list[str]:
-        tag_list = [
-            t.strip().capitalize()
-            for t in self.task_context_tags_str.split(",")
-        ]
-
-        if not tag_list:
-            tag_list = settings.DEFAULT_TASK_CONTEXT_TAG_LIST
+        tag_list = settings.DEFAULT_TASK_CONTEXT_TAGS
+        tags = ""
+        if self.task_context_tags_str:
+            tags = self.task_context_tags_str
+            tag_list = [t.strip().capitalize() for t in tags.split(",")]
 
         return tag_list

vrobbler/apps/scrobbles/dataclasses.py

@@ -3,9 +3,10 @@ from dataclasses import asdict, dataclass
 from typing import Optional
 
 from dataclass_wizard import JSONWizard
+from django import forms
 from django.contrib.auth import get_user_model
-from locations.models import GeoLocation
 from people.models import Person
+from scrobbles.forms import form_from_dataclass
 
 User = get_user_model()
 
@@ -32,14 +33,23 @@ class JSONDataclass(JSONWizard):
 
 @dataclass
 class BaseLogData(JSONDataclass):
-    details: Optional[str] = None
-    notes: Optional[str] = None
+    description: Optional[str] = None
+    notes: Optional[list[str]] = None
+
+    _excluded_fields = {}
+
+    @classmethod
+    def form(cls):
+        return form_from_dataclass(cls)
+
+    @classmethod
+    def override_fields(cls) -> dict:
+        return {}
 
 
 @dataclass
 class LongPlayLogData(JSONDataclass):
-    complete: Optional[bool] = None
-    serial_scrobble_id: Optional[int] = None
+    long_play_complete: bool = False
 
 
 @dataclass
@@ -52,4 +62,24 @@ class WithPeopleLogData(JSONDataclass):
 
         if not self.with_people_ids:
             return []
-        return [Person.objects.filter(id=pid) for pid in self.with_people_ids]
+        return [
+            Person.objects.filter(id=pid).first()
+            for pid in self.with_people_ids
+        ]
+
+    @classmethod
+    def override_fields(cls) -> dict:
+        fields = {}
+        for base in cls.mro()[1:]:
+            if hasattr(base, "override_fields"):
+                base_fields = base.override_fields()
+                fields.update(base_fields)
+        custom_fields = {
+            "with_people_ids": forms.ModelMultipleChoiceField(
+                queryset=Person.objects.all(),
+                required=False,
+                widget=forms.SelectMultiple(attrs={"size": 10}),
+            )
+        }
+        fields.update(custom_fields)
+        return fields

vrobbler/apps/scrobbles/forms.py

@@ -1,5 +1,10 @@
+from dataclasses import fields
+from typing import Union, get_args, get_origin
+
 from django import forms
 
+from people.models import Person
+
 
 class ExportScrobbleForm(forms.Form):
     """Provide options for downloading scrobbles"""
@@ -23,3 +28,81 @@ class ScrobbleForm(forms.Form):
             }
         ),
     )
+
+
+# Mapping of types to Django form field classes
+TYPE_FIELD_MAP = {
+    int: forms.IntegerField,
+    float: forms.FloatField,
+    bool: forms.BooleanField,
+    str: forms.CharField,
+    dict: forms.JSONField,
+    list: forms.JSONField,
+}
+
+# Optional: type-to-widget mapping
+TYPE_WIDGET_MAP = {
+    str: forms.TextInput(attrs={"size": 80}),
+    dict: forms.Textarea(attrs={"rows": 10, "cols": 80}),
+    list: forms.Textarea(attrs={"rows": 6, "cols": 80}),
+    bool: forms.CheckboxInput(),
+}
+
+
+def django_form_field_from_type(field_type, required=True):
+    origin = get_origin(field_type)
+
+    # Handle Optional / Union
+    if origin is Union:
+        args = get_args(field_type)
+        if type(None) in args:
+            required = False
+            non_none_type = [arg for arg in args if arg is not type(None)][0]
+            return django_form_field_from_type(
+                non_none_type, required=required
+            )
+
+    # Determine actual type
+    base_type = origin if origin else field_type
+    field_class = TYPE_FIELD_MAP.get(base_type, forms.CharField)
+    widget = TYPE_WIDGET_MAP.get(base_type)
+
+    return (
+        field_class(required=required, widget=widget)
+        if widget
+        else field_class(required=required)
+    )
+
+
+def form_from_dataclass(dataclass):
+    form_fields = {}
+    # Override notes field
+    for f in fields(dataclass):
+        if f.name in dataclass.override_fields():
+            form_fields[f.name] = dataclass.override_fields()[f.name]
+            continue
+
+        required = f.default is None and f.default_factory is None
+        form_fields[f.name] = django_form_field_from_type(
+            f.type, required=required
+        )
+
+        if f.name in dataclass._excluded_fields:
+            form_fields[f.name].disabled = True
+
+    form_cls = type(f"{dataclass.__name__}Form", (forms.Form,), form_fields)
+
+    if "notes" in form_cls.base_fields:
+        form_cls.base_fields["notes"] = forms.CharField(
+            required=False,
+            widget=forms.Textarea(attrs={"rows": 4}),
+        )
+
+        def clean_notes(self):
+            notes_str = self.cleaned_data.get("notes", "")
+            return [
+                line.strip() for line in notes_str.splitlines() if line.strip()
+            ]
+
+        form_cls.clean_notes = clean_notes
+    return form_cls

vrobbler/apps/scrobbles/management/commands/convert_task_log_data.py

@@ -0,0 +1,27 @@
+from django.core.management.base import BaseCommand
+from vrobbler.apps.tasks.utils import (
+    convert_notes_to_dict,
+    convert_old_boardgame_log_to_new,
+    convert_old_orgmode_log_to_new,
+    convert_old_todoist_log_to_new,
+)
+
+
+class Command(BaseCommand):
+    def add_arguments(self, parser):
+        parser.add_argument(
+            "--commit",
+            action="store_true",
+            help="Commit changes",
+        )
+
+    def handle(self, *args, **options):
+        commit = False
+        if options["commit"]:
+            commit = True
+        else:
+            print("No changes will be saved, use --commit to save")
+        convert_old_orgmode_log_to_new(commit)
+        convert_old_todoist_log_to_new(commit)
+        convert_notes_to_dict(commit)
+        convert_old_boardgame_log_to_new(commit)

vrobbler/apps/scrobbles/mixins.py

@@ -65,6 +65,10 @@ class ScrobblableMixin(TimeStampedModel):
     class Meta:
         abstract = True
 
+    @classmethod
+    def is_long_play_media(cls) -> bool:
+        return False
+
     def scrobble_for_user(
         self,
         user_id,
@@ -111,9 +115,9 @@ class ScrobblableMixin(TimeStampedModel):
 
     @property
     def logdata_cls(self) -> None:
-        from scrobbles.dataclasses import ScrobbleLogData
+        from scrobbles.dataclasses import BaseLogData
 
-        return ScrobbleLogData
+        return BaseLogData
 
     @property
     def subtitle(self) -> str:
@@ -136,6 +140,15 @@ class LongPlayScrobblableMixin(ScrobblableMixin):
     class Meta:
         abstract = True
 
+    @classmethod
+    def is_long_play_media(cls) -> bool:
+        return True
+
+    def is_complete(self) -> bool:
+        if self.log:
+            return bool(self.log.get("long_play_complete", None))
+        return False
+
     def get_longplay_finish_url(self):
         return reverse("scrobbles:longplay-finish", kwargs={"uuid": self.uuid})
 

vrobbler/apps/scrobbles/models.py

@@ -697,6 +697,12 @@ class Scrobble(TimeStampedModel):
 
         return super(Scrobble, self).save(*args, **kwargs)
 
+    def get_absolute_url(self):
+        if not self.uuid:
+            self.uuid = uuid4()
+            self.save()
+        return reverse("scrobbles:detail", kwargs={"uuid": self.uuid})
+
     def push_to_archivebox(self):
         pushable_media = hasattr(
             self.media_obj, "push_to_archivebox"
@@ -738,13 +744,19 @@ class Scrobble(TimeStampedModel):
             log_dict = {}
 
         try:
-            return logdata_cls.from_dict(log_dict)
-        except ParseError:
+            return logdata_cls(**log_dict)
+        except ParseError as e:
             logger.warning(
                 "Could not parse log data",
-                extra={"log_dict": log_dict, "scrobble_id": self.id},
+                extra={
+                    "log_dict": log_dict,
+                    "scrobble_id": self.id,
+                    "error": e,
+                },
             )
             return logdata_cls()
+        except TypeError as e:
+            return logdata_cls()
 
     def redirect_url(self, user_id) -> str:
         user = User.objects.filter(id=user_id).first()
@@ -1061,8 +1073,7 @@ class Scrobble(TimeStampedModel):
         return media_obj
 
     def __str__(self):
-        timestamp = self.timestamp.strftime("%Y-%m-%d")
-        return f"Scrobble of {self.media_obj} ({timestamp})"
+        return f"Scrobble of {self.media_obj} ({self.timestamp})"
 
     def calc_reading_duration(self) -> int:
         duration = 0

vrobbler/apps/scrobbles/scrobblers.py

@@ -411,7 +411,7 @@ def email_scrobble_board_game(
                     except IndexError:
                         second = 0
 
-            log_data["details"] = play_dict.get("comments")
+            log_data["notes"] = [play_dict.get("comments")]
         log_data["expansion_ids"] = []
         try:
             base_game = base_games[play_dict.get("gameRefId")]
@@ -587,9 +587,9 @@ def todoist_scrobble_update_task(
         )
         return
 
-    existing_notes = scrobble.log.get("notes", {})
-    existing_notes[todoist_note.get("todoist_id")] = todoist_note.get("notes")
-    scrobble.log["notes"] = existing_notes
+    if not scrobble.log.get("notes"):
+        scrobble.log["notes"] = []
+    scrobble.log["notes"].append(todoist_note.get("notes"))
     scrobble.save(update_fields=["log"])
     logger.info(
         "[todoist_scrobble_update_task] todoist note added",
@@ -615,7 +615,7 @@ def todoist_scrobble_task(
     )
     task = Task.find_or_create(title)
 
-    timestamp = pendulum.parse(todoist_task.get("updated_at", timezone.now()))
+    timestamp = pendulum.parse(todoist_task.pop("updated_at", timezone.now()))
     in_progress_scrobble = Scrobble.objects.filter(
         user_id=user_id,
         in_progress=True,
@@ -657,8 +657,12 @@ def todoist_scrobble_task(
         )
         return todoist_scrobble_task_finish(todoist_task, user_id, timestamp)
 
-    # Default to create new scrobble "if not in_progress_scrobble and in_progress_in_todoist"
-    # TODO Should use updated_at from TOdoist, but parsing isn't working
+    todoist_task["title"] = todoist_task.pop("description")
+    todoist_task["description"] = todoist_task.pop("details")
+    todoist_task["labels"] = todoist_task.pop("todoist_label_list", [])
+    todoist_task.pop("todoist_type")
+    todoist_task.pop("todoist_event")
+
     scrobble_dict = {
         "user_id": user_id,
         "timestamp": timestamp,
@@ -686,8 +690,8 @@ def emacs_scrobble_update_task(
     scrobble = Scrobble.objects.filter(
         in_progress=True,
         user_id=user_id,
-        log__source_id=emacs_id,
-        log__source="orgmode",
+        log__orgmode_id=emacs_id,
+        source="Org-mode",
     ).first()
 
     if not scrobble:
@@ -736,18 +740,18 @@ def emacs_scrobble_task(
     stopped: bool = False,
     user_context_list: list[str] = [],
 ) -> Scrobble | None:
-    source_id = task_data.get("source_id")
+    orgmode_id = task_data.get("source_id")
     title = get_title_from_labels(
         task_data.get("labels", []), user_context_list
     )
 
     task = Task.find_or_create(title)
 
-    timestamp = pendulum.parse(task_data.get("updated_at", timezone.now()))
+    timestamp = pendulum.parse(task_data.pop("updated_at", timezone.now()))
     in_progress_scrobble = Scrobble.objects.filter(
         user_id=user_id,
         in_progress=True,
-        log__source_id=source_id,
+        log__orgmode_id=orgmode_id,
         log__source="orgmode",
         task=task,
     ).last()
@@ -756,7 +760,7 @@ def emacs_scrobble_task(
         logger.info(
             "[emacs_scrobble_task] cannot stop already stopped task",
             extra={
-                "emacs_id": source_id,
+                "orgmode_id": orgmode_id,
             },
         )
         return
@@ -765,7 +769,7 @@ def emacs_scrobble_task(
         logger.info(
             "[emacs_scrobble_task] cannot start already started task",
             extra={
-                "emacs_id": source_id,
+                "ormode_id": orgmode_id,
             },
         )
         return in_progress_scrobble
@@ -775,7 +779,7 @@ def emacs_scrobble_task(
         logger.info(
             "[emacs_scrobble_task] finishing",
             extra={
-                "emacs_id": source_id,
+                "orgmode_id": orgmode_id,
             },
         )
         in_progress_scrobble.stop(timestamp=timestamp, force_finish=True)
@@ -786,11 +790,17 @@ def emacs_scrobble_task(
 
     notes = task_data.pop("notes")
     if notes:
-        task_data["notes"] = []
-        for note in notes:
-            task_data["notes"].append(
-                {note.get("timestamp"): note.get("content")}
-            )
+        task_data["notes"] = [note.get("content") for note in notes]
+    task_data["title"] = task_data.pop("description")
+    task_data["description"] = task_data.pop("body")
+    task_data["labels"] = task_data.pop("labels")
+
+    task_data["orgmode_id"] = task_data.pop("source_id")
+    task_data["orgmode_state"] = task_data.pop("state")
+    task_data["orgmode_properties"] = task_data.pop("properties")
+    task_data["orgmode_drawers"] = task_data.pop("drawers")
+    task_data["orgmode_timestamps"] = task_data.pop("timestamps")
+    task_data.pop("source")
 
     scrobble_dict = {
         "user_id": user_id,

vrobbler/apps/scrobbles/templatetags/form_tags.py

@@ -0,0 +1,11 @@
+from django import template
+
+register = template.Library()
+
+
+@register.filter(name="add_class")
+def add_class(field, css_class):
+    # If the widget is CheckboxInput, skip adding 'form-control'
+    if field.field.widget.__class__.__name__ == "CheckboxInput":
+        return field.as_widget()
+    return field.as_widget(attrs={"class": css_class})

vrobbler/apps/scrobbles/urls.py

@@ -95,6 +95,11 @@ urlpatterns = [
         views.ScrobbleLongPlaysView.as_view(),
         name="long-plays",
     ),
+    path(
+        "scrobble/<slug:uuid>/",
+        views.ScrobbleDetailView.as_view(),
+        name="detail",
+    ),
     path("scrobble/<slug:uuid>/start/", views.scrobble_start, name="start"),
     path("scrobble/<slug:uuid>/finish/", views.scrobble_finish, name="finish"),
     path("scrobble/<slug:uuid>/cancel/", views.scrobble_cancel, name="cancel"),

vrobbler/apps/scrobbles/views.py

@@ -4,12 +4,13 @@ import logging
 from datetime import datetime, timedelta
 from dateutil.relativedelta import relativedelta
 
+from django.shortcuts import redirect
 import pendulum
 import pytz
 from django.apps import apps
 from django.contrib import messages
 from django.contrib.auth.mixins import LoginRequiredMixin
-from django.db.models import Count, Q
+from django.db.models import Count, Q, Max
 from django.db.models.query import QuerySet
 from django.http import FileResponse, HttpResponseRedirect, JsonResponse
 from django.urls import reverse_lazy
@@ -75,12 +76,17 @@ class ScrobbleableListView(ListView):
             user_filter = Q(scrobble__user=self.request.user)
 
         queryset = (
-            queryset.filter(user_filter).annotate(
-                scrobble_count=Count("scrobble")
-            ).filter(scrobble_count__gt=0).order_by("-scrobble_count")
+            queryset.filter(user_filter)
+            .annotate(
+                scrobble_count=Count("scrobble", distinct=True),
+                last_scrobble=Max("scrobble__timestamp"),
+            )
+            .filter(scrobble_count__gt=0)
+            .order_by("-last_scrobble")
         )
         return queryset
 
+
 class ScrobbleableDetailView(DetailView):
     model = None
     slug_field = "uuid"
@@ -926,3 +932,57 @@ class ScrobbleStatusView(LoginRequiredMixin, TemplateView):
         ).first()
 
         return data
+
+
+class ScrobbleDetailView(DetailView):
+    model = Scrobble
+    slug_field = "uuid"
+    slug_url_kwarg = "uuid"
+
+    def get_form_class(self):
+        return self.object.media_obj.logdata_cls.form()
+
+    def get_form(self):
+        FormClass = self.get_form_class()
+
+        log = self.object.log or {}
+        initial_notes = log.get("notes", [])
+        if isinstance(initial_notes, list):
+            notes_str = "\n".join(initial_notes)
+            notes_str_fixed = notes_str.encode("utf-8").decode(
+                "unicode_escape"
+            )
+            log["notes"] = notes_str_fixed
+
+        return FormClass(initial=log)
+
+    def post(self, request, *args, **kwargs):
+        self.object = self.get_object()
+        FormClass = self.get_form_class()
+        form = FormClass(request.POST)
+
+        if form.is_valid():
+            data = form.cleaned_data.copy()
+
+            for field_name, field in form.fields.items():
+                if field.disabled:
+                    original_value = (self.object.log or {}).get(field_name)
+                    data[field_name] = original_value
+
+            if "with_people_ids" in data:
+                data["with_people_ids"] = [
+                    p.id for p in data["with_people_ids"]
+                ]
+
+            self.object.log = data
+            self.object.save(update_fields=["log"])
+            return redirect(self.object.get_absolute_url())
+
+        context = self.get_context_data(log_form=form)
+        return self.render_to_response(context)
+
+    def get_context_data(self, **kwargs):
+        context = super().get_context_data(**kwargs)
+        if "log_form" not in context:
+            context["log_form"] = self.get_form()
+        return context

vrobbler/apps/tasks/models.py

@@ -1,11 +1,10 @@
 from dataclasses import dataclass
-from datetime import datetime
 from typing import Optional
 
 from django.apps import apps
 from django.db import models
 from django.urls import reverse
-from scrobbles.dataclasses import JSONDataclass
+from scrobbles.dataclasses import BaseLogData
 from scrobbles.mixins import LongPlayScrobblableMixin, ScrobblableConstants
 
 BNULL = {"blank": True, "null": True}
@@ -14,27 +13,29 @@ TODOIST_TASK_URL = "https://app.todoist.com/app/task/{id}"
 
 
 @dataclass
-class TaskLogData(JSONDataclass):
-    description: Optional[str] = None
+class TaskLogData(BaseLogData):
     title: Optional[str] = None
-    project: Optional[str] = None
-    notes: Optional[dict] = None
-    updated_at: Optional[str] = None
+    labels: Optional[list[str]] = None
+
+    orgmode_id: Optional[str] = None
+    orgmode_state: Optional[str] = None
+    orgmode_properties: Optional[dict] = None
+    orgmode_drawers: Optional[list] = None
+    orgmode_timestamps: Optional[list] = None
+
     todoist_id: Optional[str] = None
-    todoist_event: Optional[str] = None
-    todoist_type: Optional[str] = None
-    todoist_type: Optional[str] = None
-    todoist_label_list: Optional[list] = None
     todoist_project_id: Optional[str] = None
-    body: Optional[str] = None
-    state: Optional[str] = None
-    labels: Optional[str] = None
-    properties: Optional[list] = None
-    drawers: Optional[list] = None
-    source: Optional[str] = None
-    source_id: Optional[str] = None
-    timestamps: Optional[list] = None
-    details: Optional[str] = None
+
+    _excluded_fields = {
+        "labels",
+        "orgmode_id",
+        "orgmode_state",
+        "orgmode_properties",
+        "orgmode_drawers",
+        "orgmode_timestamps",
+        "todoist_id",
+        "todoist_project_id",
+    }
 
     def notes_as_str(self) -> str:
         """Return formatted notes with line breaks and no keys"""
@@ -42,6 +43,7 @@ class TaskLogData(JSONDataclass):
         if isinstance(self.notes, list):
             note_block = "</br>".join(self.notes)
 
+        # DEPRECATED ... we don't store notes in dicts anymore
         if isinstance(self.notes, dict):
             for id, content in self.notes.items():
                 note_block += content + "</br>"

vrobbler/apps/tasks/utils.py

@@ -1,22 +1,106 @@
 import logging
+from datetime import timedelta
 
 from django.conf import settings
+from scrobbles.models import Scrobble
 
 logger = logging.getLogger(__name__)
 
-def get_title_from_labels(labels: list[str], user_context_labels: list[str] = []) -> str:
+
+def get_title_from_labels(
+    labels: list[str], user_context_labels: list[str] = []
+) -> str:
     title = "Unknown"
-    task_context_labels: list = user_context_labels or settings.DEFAULT_TASK_CONTEXT_TAG_LIST
     for label in labels:
-        # TODO We may also want to take a user list of labels instead
         label = label.capitalize()
-        if label in task_context_labels:
+        if label in user_context_labels:
             title = label
             continue
 
     if title == "Unknown":
         logger.warning(
             "Missing a configured title context for task",
-            extra={"labels": labels, "task_context_labels": task_context_labels},
+            extra={
+                "labels": labels,
+                "user_context_labels": user_context_labels,
+            },
         )
     return title
+
+
+def convert_old_orgmode_log_to_new(commit=False):
+    scrobbles = Scrobble.objects.filter(
+        source="Org-mode", log__has_key="drawers"
+    )
+    for scrobble in scrobbles:
+        scrobble.log["title"] = scrobble.log.pop("description")
+        scrobble.log["description"] = scrobble.log.pop("details")
+
+        scrobble.log["orgmode_body"] = scrobble.log.pop("body")
+        scrobble.log["orgmode_state"] = scrobble.log.pop("state")
+        scrobble.log["orgmode_properties"] = scrobble.log.pop("properties")
+        scrobble.log["orgmode_drawers"] = scrobble.log.pop("drawers")
+        scrobble.log["orgmode_timestamps"] = scrobble.log.pop("timestamps")
+        scrobble.log["orgmode_id"] = scrobble.log.pop("source_id")
+
+        if commit:
+            scrobble.save(update_fields=["log"])
+    print(f"Updated {scrobbles.count()} orgmode tasks logs")
+
+
+def convert_old_todoist_log_to_new(commit=False):
+    scrobbles = Scrobble.objects.filter(
+        source="Todoist", log__has_key="todoist_type"
+    )
+    for scrobble in scrobbles:
+        scrobble.log["title"] = scrobble.log.pop("description")
+        scrobble.log["description"] = scrobble.log.pop("details")
+        scrobble.log["todoist_id"] = scrobble.log.pop("source_id")
+        scrobble.log["labels"] = scrobble.log.pop("todoist_label_list")
+
+        scrobble.log.pop("todoist_type")
+        scrobble.log.pop("todoist_event")
+
+        print(f"Updating scrobble {scrobble.id}")
+        if commit:
+            scrobble.save(update_fields=["log"])
+    print(f"Updated {scrobbles.count()} todoist tasks logs")
+
+
+def convert_notes_to_dict(commit=False):
+    scrobbles = Scrobble.objects.filter(log__notes__isnull=False)
+    count = 0
+    for scrobble in scrobbles:
+        if isinstance(scrobble.log, str):
+            print(f"Converting {scrobble} string note to dict")
+            if scrobble.log.get("notes") == "":
+                scrobble.log.pop("notes")
+            key = str(int(scrobble.timestamp.timestamp()))
+            notes = scrobble.log.pop("notes")
+            scrobble.log = {}
+            scrobble.log["notes"] = {key: notes}
+            count += 1
+
+        if isinstance(scrobble.log.get("notes"), list):
+            note_list = scrobble.log.pop("notes")
+            if all(isinstance(item, dict) for item in note_list):
+                scrobble.log["notes"] = [
+                    value for d in note_list for value in d.values()
+                ]
+            count += 1
+        if commit:
+            scrobble.save(update_fields=["log"])
+    print(f"Updated {count} todoist tasks scrobbles")
+
+
+def convert_old_boardgame_log_to_new(commit=False):
+    scrobbles = Scrobble.objects.filter(
+        board_game__isnull=False, log__has_key="notes"
+    )
+    for scrobble in scrobbles:
+        if isinstance(scrobble.log.get("notes"), str):
+            scrobble.log["notes"] = [scrobble.log.pop("notes")]
+
+        if commit:
+            scrobble.save(update_fields=["log"])
+    print(f"Updated {scrobbles.count()} board game scrobbles")

vrobbler/apps/videogames/models.py

@@ -3,6 +3,7 @@ import logging
 from typing import Optional
 from uuid import uuid4
 
+from django import forms
 from django.conf import settings
 from django.contrib.auth import get_user_model
 from django.db import models
@@ -30,11 +31,29 @@ class VideoGameLogData(BaseLogData, LongPlayLogData, WithPeopleLogData):
     emulated: Optional[bool] = False
     emulator: Optional[str] = None
 
+    @property
     def platform(self):
         if not self.platform_id:
             return
         return VideoGamePlatform.objects.filter(id=self.platform_id).first()
 
+    @classmethod
+    def override_fields(cls) -> dict:
+        fields = {}
+        for base in cls.mro()[1:]:
+            if hasattr(base, "override_fields"):
+                base_fields = base.override_fields()
+                fields.update(base_fields)
+        custom_fields = {
+            "platform_id": forms.ModelChoiceField(
+                queryset=VideoGamePlatform.objects.all(),
+                required=False,
+                widget=forms.Select(),
+            )
+        }
+        fields.update(custom_fields)
+        return fields
+
 
 class VideoGamePlatform(TimeStampedModel):
     name = models.CharField(max_length=255)
@@ -51,6 +70,19 @@ class VideoGamePlatform(TimeStampedModel):
         )
 
 
+@dataclass
+class VideoGameLogData(BaseLogData, LongPlayLogData, WithPeopleLogData):
+    platform_id: Optional[int] = None
+    emulated: Optional[bool] = False
+    emulator: Optional[str] = None
+
+    @property
+    def platform(self) -> VideoGamePlatform | None:
+        if not self.platform_id:
+            return
+        return VideoGamePlatform.objects.filter(id=self.platform_id).first()
+
+
 class VideoGameCollection(TimeStampedModel):
     name = models.CharField(max_length=255)
     uuid = models.UUIDField(default=uuid4, editable=False, **BNULL)

vrobbler/apps/videogames/views.py

@@ -1,17 +1,21 @@
-from django.views import generic
 from videogames.models import VideoGame, VideoGamePlatform
+from scrobbles.views import (
+    ScrobbleImportListView,
+    ScrobbleableDetailView,
+    ScrobbleableListView,
+)
 
 
-class VideoGameListView(generic.ListView):
+class VideoGameListView(ScrobbleableListView):
     model = VideoGame
-    paginate_by = 20
+    paginate_by = 40
 
 
-class VideoGameDetailView(generic.DetailView):
+class VideoGameDetailView(ScrobbleableDetailView):
     model = VideoGame
     slug_field = "uuid"
 
 
-class VideoGamePlatformDetailView(generic.DetailView):
+class VideoGamePlatformDetailView(ScrobbleableDetailView):
     model = VideoGamePlatform
     slug_field = "uuid"

vrobbler/templates/base.html

@@ -329,5 +329,21 @@
         </div>
 
         {% block extra_js %}{% endblock %}
+        <script>
+        (() => {
+        'use strict'
+        const forms = document.querySelectorAll('.needs-validation')
+        Array.from(forms).forEach(form => {
+            form.addEventListener('submit', event => {
+            if (!form.checkValidity()) {
+                event.preventDefault()
+                event.stopPropagation()
+            }
+            form.classList.add('was-validated')
+            }, false)
+        })
+        })()
+        </script>
+
     </body>
 </html>

vrobbler/templates/beers/beer_detail.html

@@ -57,7 +57,7 @@
                 <tbody>
                     {% for scrobble in scrobbles.all|dictsortreversed:"timestamp" %}
                     <tr>
-                        <td>{{scrobble.local_timestamp}}</td>
+                        <td><a href="{{scrobble.get_absolute_url}}">{{scrobble.local_timestamp}}</a></td>
                     </tr>
                     {% endfor %}
                 </tbody>

vrobbler/templates/boardgames/boardgame_detail.html

@@ -62,7 +62,7 @@
                 <tbody>
                     {% for scrobble in scrobbles.all|dictsortreversed:"timestamp" %}
                     <tr>
-                        <td>{{scrobble.local_timestamp}}</td>
+                        <td><a href={{scrobble.get_absolute_url}}>{{scrobble.local_timestamp}}</a></td>
                         <td>{{scrobble.media_obj.publisher}}</td>
                         <td>{% if scrobble.logdata.player_log %}{{scrobble.logdata.player_log}}{% else %}No data{% endif %}</td>
                     </tr>

vrobbler/templates/books/book_detail.html

@@ -27,14 +27,6 @@
 </div>
 <div class="row">
     <p>{{scrobbles.count}} scrobbles</p>
-    <p>Read {{scrobbles.last.book_pages_read}} pages{% if scrobbles.last.long_play_complete %} and completed{% else %}{% endif %}</p>
-    <p>
-        {% if scrobbles.last.long_play_complete == True %}
-        <a href="">Read again</a>
-        {% else %}
-        <a href="">Resume reading</a>
-        {% endif %}
-    </p>
 </div>
 <div class="row">
     <div class="col-md">
@@ -52,7 +44,7 @@
                 <tbody>
                     {% for scrobble in scrobbles.all|dictsortreversed:"timestamp" %}
                     <tr>
-                        <td>{{scrobble.local_timestamp}}</td>
+                        <td><a href="{{scrobble.get_absolute_url}}">{{scrobble.local_timestamp}}</a></td>
                         <td>{% if scrobble.long_play_complete == True %}Yes{% endif %}</td>
                         <td>{% if scrobble.in_progress %}Now reading{% else %}{{scrobble.session_pages_read}}{% endif %}</td>
                         <td>{% for author in scrobble.book.authors.all %}<a href="{{author.get_absolute_url}}">{{author}}</a>{% if not forloop.last %}, {% endif %}{% endfor %}</td>

vrobbler/templates/scrobbles/scrobble_detail.html

@@ -0,0 +1,38 @@
+{% extends "base_list.html" %}
+{% load form_tags %}
+{% load mathfilters %}
+{% load static %}
+
+{% block title %}{{object.name}}{% endblock %}
+
+{% block lists %}
+
+<div class="row">
+
+<h1>{{ object.media_obj }} - {{object.media_type}}</h1>
+
+<!-- Your existing detail page content -->
+<p>Rate: {{object.logdata.avg_seconds_per_page}}s per page</p>
+
+<h2>Edit Log</h2>
+<form method="post" class="needs-validation" novalidate>
+  {% csrf_token %}
+  {% for field in log_form %}
+    <div class="mb-3">
+      <label for="{{ field.id_for_label }}" class="form-label">{{ field.label }}</label>
+      {{ field|add_class:"form-control" }}
+      {% if field.help_text %}
+        <div class="form-text">{{ field.help_text }}</div>
+      {% endif %}
+      {% for error in field.errors %}
+        <div class="invalid-feedback d-block">{{ error }}</div>
+      {% endfor %}
+    </div>
+  {% endfor %}
+
+  <button type="submit" class="btn btn-primary">Save</button>
+</form>
+
+</div>
+
+{% endblock %}

vrobbler/templates/tasks/task_detail.html

@@ -62,7 +62,7 @@
                 <tbody>
                     {% for scrobble in scrobbles.all|dictsortreversed:"timestamp" %}
                     <tr>
-                        <td>{{scrobble.local_timestamp}}</td>
+                        <td><a href="{{scrobble.get_absolute_url}}">{{scrobble.local_timestamp}}</a></td>
                         <td><a href="{{scrobble.get_media_source_url}}">{{scrobble.logdata.description}}</a></td>
                         <td>{{scrobble.logdata.notes_as_str|safe}}</td>
                         <td>{{scrobble.source}}</td>

vrobbler/templates/videogames/videogame_detail.html

@@ -60,15 +60,8 @@
 </div>
 <div class="row">
     <p>{{scrobbles.count}} scrobbles</p>
-    {% if scrobbles.last.long_play_seconds %}
-    <p>{{scrobbles.last.long_play_seconds|natural_duration}}{% if scrobbles.last.long_play_complete %} and completed{% else %} spent playing{% endif %}</p>
-    {% endif  %}
     <p>
-        {% if scrobbles.last.long_play_complete == True %}
         <a href="">Play again</a>
-        {% else %}
-        <a href="{{object.start_url}}">Resume playing</a>
-        {% endif %}
     </p>
 </div>
 <div class="row">
@@ -88,7 +81,8 @@
                 <tbody>
                     {% for scrobble in scrobbles.all|dictsortreversed:"timestamp" %}
                     <tr>
-                        <td>{{scrobble.local-timestamp}}</td>
+
+                        <td><a href="{{scrobble.get_absolute_url}}">{{scrobble.local_timestamp}}</a></td>
                         <td>{% if scrobble.long_play_complete == True %}Yes{% else %}Not yet{% endif %}</td>
                         <td>{% if scrobble.in_progress %}Now playing{% else %}{{scrobble.playback_position_seconds|natural_duration}}{% endif %}</td>
                         <td>{% for platform in scrobble.video_game.platforms.all %}<a href="{{platform.get_absolute_url}}">{{platform}}</a>{% if not forloop.last %}, {% endif %}{% endfor %}</td>