[tasks] Fix catch for no scrobble available

This commit is contained in:
2024-10-15 14:58:34 -04:00
parent 8fa538dbee
commit c4359a2331
2 changed files with 15 additions and 3 deletions

View File

@ -310,15 +310,24 @@ def manual_scrobble_from_url(url: str, user_id: int) -> Scrobble:
return eval(scrobble_fn)(item_id, user_id)
def todoist_scrobble_task_finish(todoist_task: dict, user_id: int) -> Scrobble:
def todoist_scrobble_task_finish(
todoist_task: dict, user_id: int
) -> Optional[Scrobble]:
scrobble = Scrobble.objects.filter(
user_id=user_id, log__todoist_id=todoist_task.get("todoist_id")
).first()
if not scrobble:
logger.info(
"[todoist_scrobble_task_finish] todoist webhook finish called on missing task"
)
return
if not scrobble.in_progress or scrobble.played_to_completion:
logger.warning(
logger.info(
"[todoist_scrobble_task_finish] todoist webhook finish called on finished task"
)
return
scrobble.stop(force_finish=True)

View File

@ -67,7 +67,10 @@ def todoist_webhook(request):
scrobble = todoist_scrobble_task(todoist_task, user_id)
if not scrobble:
return Response({}, status=status.HTTP_400_BAD_REQUEST)
return Response(
{"error": "No scrobble found to be updated"},
status=status.HTTP_400_BAD_REQUEST,
)
logger.info(
"[todoist_webhook] finished",