From 852a257159f93142ff87481af67fc21ff10c5b68 Mon Sep 17 00:00:00 2001 From: Colin Powell Date: Thu, 18 Jun 2026 16:59:03 -0400 Subject: [PATCH] [scrobbles] Clean up a TODO already done --- PROJECT.org | 25 +++++++++++++++++++++++++ vrobbler/apps/scrobbles/scrobblers.py | 2 -- 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/PROJECT.org b/PROJECT.org index 1f758bf..cb80dc5 100644 --- a/PROJECT.org +++ b/PROJECT.org @@ -579,6 +579,18 @@ named constants for maintainability. - ~vrobbler/apps/scrobbles/importers/tsv.py~ (line 55) -- ="S"= completion status +** TODO [#A] Deduplicate BGG plays before posting :boardgames:bgg:duplication: +:PROPERTIES: +:ID: e9b842bf-0049-42e7-a060-f3ebd0067d2f +:END: + +*** Description + +No check for existing BGG plays before posting, which can create duplicates. +Should look up past plays by =bggeek_id= first. + +File: ~vrobbler/apps/boardgames/bgg.py~ (line 117) + ** TODO [#C] Clean up naming of =bgsplay= parsing :importers:refactoring: :PROPERTIES: :ID: c751dbbc-464a-4e63-9fe3-e034303f7b54 @@ -591,6 +603,19 @@ a helper method to create board game scrobbles given a json blob. It's independent of the email flow it was originally creatdd for ** TODO [#B] Is there way to create unique slugs for media instances :media_types: + +** TODO [#A] Check for existing book scrobble and update page count :books:scrobbling: +:PROPERTIES: +:ID: 1a0609bc-6b16-4da4-96c1-59588229e4b4 +:END: + +*** Description + +File: ~vrobbler/apps/scrobbles/scrobblers.py~ (line 330) + +When scrobbling a book (comic), the code doesn't check for prior scrobbles to +update reading progress. Needed for proper page-count tracking. + * Version 55.2 [2/2] ** DONE [#A] Fix bug in scrobble id in calendar view :templates: :PROPERTIES: diff --git a/vrobbler/apps/scrobbles/scrobblers.py b/vrobbler/apps/scrobbles/scrobblers.py index a3b75df..e1a007f 100644 --- a/vrobbler/apps/scrobbles/scrobblers.py +++ b/vrobbler/apps/scrobbles/scrobblers.py @@ -330,8 +330,6 @@ def manual_scrobble_book( source = READCOMICSONLINE_URL.replace("https://", "") - # TODO: Check for scrobble of this book already and if so, update the page count - book = Book.find_or_create(title, url=url, enrich=True) scrobble_dict = {