From 801672124ffc375479e4d483b28dcb9990be5a02 Mon Sep 17 00:00:00 2001 From: Colin Powell Date: Thu, 4 Jun 2026 10:47:22 -0400 Subject: [PATCH] [notifications] Fix duplicate ntfy for board games --- PROJECT.org | 19 +++++++++++++++++-- vrobbler/apps/scrobbles/scrobblers.py | 1 - 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/PROJECT.org b/PROJECT.org index f0a1d90..30d4da7 100644 --- a/PROJECT.org +++ b/PROJECT.org @@ -93,7 +93,7 @@ fetching and simple saving. :LOGBOOK: CLOCK: [2025-07-09 Wed 09:55]--[2025-07-09 Wed 10:15] => 0:20 :END: -* Backlog [2/18] :vrobbler:project:personal: +* Backlog [3/19] :vrobbler:project:personal: ** TODO [#C] Add sentiment parsing for Scrobbles with notes :vrobbler:project:scrobbles:sentiment: :PROPERTIES: :ID: 37781d6a-f3b0-48b2-bf98-33c2c791cf85 @@ -506,6 +506,9 @@ different in the webhook than what's in the scrobble.log, update the comment in the scrobble.log ** TODO [#B] For any scrobble detail page with notes display them better :templates:notes:scrobbles: +:PROPERTIES: +:ID: c0dcf9da-227f-4a22-bcd9-9d46053607d9 +:END: *** Description @@ -515,7 +518,19 @@ We should update note rendering to be a simple newest to oldest display in a single column with the timestamp has a small header, and the content rendered as markdown with a small bar or horizontal divider marking them from the next note. -** TODO [#A] Board game imports send duplicate ntfy message :bug:notifications:boardgames: +** TODO [#A] Imports should send notifications :feature:notifications:imports: +:PROPERTIES: +:ID: 6f78f8d5-ecaa-4d8a-a666-ae4e27653191 +:END: + +*** Description + +Currently importing board games sends out a ntfy message when a scrobble is +created. + +We should do the same thing for other import types; namely: gpx, ebird, and scale. + +** DONE [#A] Board game imports send duplicate ntfy message :bug:notifications:boardgames: :PROPERTIES: :ID: 8f067432-0399-4b79-9e93-727edcccedbd :END: diff --git a/vrobbler/apps/scrobbles/scrobblers.py b/vrobbler/apps/scrobbles/scrobblers.py index 115def9..311c18d 100644 --- a/vrobbler/apps/scrobbles/scrobblers.py +++ b/vrobbler/apps/scrobbles/scrobblers.py @@ -562,7 +562,6 @@ def email_scrobble_board_game( scrobble.played_to_completion = True scrobble.save() scrobbles_created.append(scrobble) - ScrobbleNtfyNotification(scrobble).send() return scrobbles_created