From 79fc407c336c0deef3cf2cdf90279d0a9f612867 Mon Sep 17 00:00:00 2001 From: Colin Powell Date: Fri, 8 Mar 2024 16:53:44 -0500 Subject: [PATCH] [scrobbles] Fix bug in can be updated method --- vrobbler/apps/scrobbles/models.py | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/vrobbler/apps/scrobbles/models.py b/vrobbler/apps/scrobbles/models.py index 1ecd254..fcc01b3 100644 --- a/vrobbler/apps/scrobbles/models.py +++ b/vrobbler/apps/scrobbles/models.py @@ -751,8 +751,15 @@ class Scrobble(TimeStampedModel): }, ) return False - - updatable = True + logger.info( + "[scrobbling] can be updated", + extra={ + "media_id": self.media_obj.id, + "scrobble_id": self.id, + "media_type": self.media_type, + }, + ) + return True @property def media_obj(self): @@ -838,12 +845,10 @@ class Scrobble(TimeStampedModel): "media_type": mtype, "media_id": media.id, "scrobble_data": scrobble_data, - "percent_played": scrobble.percent_played - if scrobble - else None, + "percent_played": scrobble.percent_played if scrobble else 0, "can_be_updated": scrobble.can_be_updated if scrobble - else None, + else False, }, )