[tasks] Clean up todoist scrobbling

vrobbler/apps/profiles/views.py

@@ -1,8 +1,7 @@
 from django.contrib.auth.mixins import LoginRequiredMixin
-from django.urls import reverse_lazy
 from django.http.response import HttpResponseBadRequest
+from django.urls import reverse_lazy
 from django.views.generic import FormView
-
 from profiles.forms import UserProfileForm
 
 
@@ -27,4 +26,5 @@ class ProfileFormView(LoginRequiredMixin, FormView):
     def get_context_data(self, **kwargs):
         context = super().get_context_data(**kwargs)
         context["user_id"] = self.request.user.id
+        context["profile"] = self.request.user.profile
         return context

vrobbler/apps/scrobbles/urls.py

@@ -1,6 +1,6 @@
 from django.urls import path
 from scrobbles import views
-from tasks.webhooks import EmacsWebhookView, todoist_webhook
+from tasks.webhooks import EmacsWebhookView, TodoistWebhookView
 
 app_name = "scrobbles"
 
@@ -82,7 +82,7 @@ urlpatterns = [
         views.MopidyWebhookView.as_view(),
         name="mopidy-webhook",
     ),
-    path("webhook/todoist/", todoist_webhook, name="todoist-webhook"),
+    path("webhook/todoist/", TodoistWebhookView.as_view(), name="todoist-webhook"),
     path("webhook/emacs/", EmacsWebhookView.as_view(), name="emacs_webhook"),
     path("export/", views.export, name="export"),
     path(

vrobbler/apps/tasks/webhooks.py

@@ -1,11 +1,12 @@
 import json
 import logging
 
-from django.views.decorators.csrf import csrf_exempt
+from django.utils import timezone
 from profiles.models import UserProfile
-from rest_framework.decorators import permission_classes
-from rest_framework.permissions import IsAuthenticated
 from rest_framework import status
+from rest_framework.authentication import BaseAuthentication
+from rest_framework.exceptions import AuthenticationFailed
+from rest_framework.permissions import BasePermission
 from rest_framework.response import Response
 from rest_framework.views import APIView
 from scrobbles.scrobblers import (
@@ -18,101 +19,140 @@ from scrobbles.scrobblers import (
 logger = logging.getLogger(__name__)
 
 
-@csrf_exempt
+class TodoistTokenAuthentication(BaseAuthentication):
-@permission_classes([IsAuthenticated])
+    keyword = "Bearer"
-def todoist_webhook(request):
-    post_data = request.data
-    logger.info(
-        "[todoist_webhook] called",
-        extra={"post_data": post_data},
-    )
-    todoist_task = {}
-    todoist_note = {}
-    todoist_type, todoist_event = post_data.get("event_name").split(":")
-    event_data = post_data.get("event_data", {})
-    is_item_type = todoist_type == "item"
-    is_note_type = todoist_tyllll = "note"
-    new_labels = event_data.get("labels", [])
-    old_labels = (
-        post_data.get("event_data_extra", {}).get("old_item", {}).get("labels", [])
-    )
-    # TODO Don't hard code status strings in here
-    is_updated = todoist_event in ["updated"]
-    is_added = todoist_event in ["added"]
 
-    task_started = "inprogress" in new_labels and "inprogress" not in old_labels
+    def authenticate(self, request):
-    task_stopped = "inprogress" not in new_labels and "inprogress" in old_labels
+        auth_header = request.META.get("HTTP_AUTHORIZATION", "")
 
-    if is_item_type and is_updated and (task_started or task_stopped):
+        if not auth_header:
-        todoist_task = {
+            return None
-            "todoist_id": event_data.get("id"),
-            "todoist_label_list": event_data.get("labels"),
-            "todoist_type": todoist_type,
-            "todoist_event": todoist_event,
-            "updated_at": event_data.get("updated_at"),
-            "todoist_project_id": event_data.get("project_id"),
-            "description": event_data.get("content"),
-            "details": event_data.get("description"),
-        }
-    if is_note_type and is_added:
-        task_data = event_data.get("item", {})
-        todoist_note = {
-            "task_id": event_data.get("item_id"),
-            "todoist_id": event_data.get("id"),
-            "todoist_label_list": task_data.get("labels"),
-            "todoist_type": todoist_type,
-            "todoist_event": todoist_event,
-            "updated_at": task_data.get("updated_at"),
-            "details": task_data.get("description"),
-            "notes": event_data.get("content"),
-            "is_deleted": (True if event_data.get("is_deleted") == "true" else False),
-        }
 
-    if (is_added and not todoist_note) or (is_updated and not todoist_task):
+        parts = auth_header.split()
-        logger.info(
+
-            "[todoist_webhook] ignoring wrong todoist type, event or labels",
+        if len(parts) != 2 or parts[0] != self.keyword:
-            extra={
+            return None
+
+        token = parts[1]
+
+        profile = UserProfile.objects.filter(todoist_auth_key=token).first()
+
+        if not profile:
+            raise AuthenticationFailed("Invalid token")
+
+        if not profile.user:
+            raise AuthenticationFailed("No user associated with token")
+
+        return (profile.user, profile)
+
+
+class IsAuthenticatedForTodoist(BasePermission):
+    def has_permission(self, request):
+        return (
+            hasattr(request, "user") and request.user and request.user.is_authenticated
+        )
+
+
+class TodoistWebhookView(APIView):
+    authentication_classes = [TodoistTokenAuthentication]
+    permission_classes = [IsAuthenticatedForTodoist]
+
+    @property
+    def logger(self):
+        return logger
+
+    def post(self, request):
+        user_profile = request.auth
+
+        post_data = request.data
+        self.logger.info(
+            "[todoist_webhook] called",
+            extra={"post_data": post_data},
+        )
+        todoist_task = {}
+        todoist_note = {}
+        todoist_type, todoist_event = post_data.get("event_name").split(":")
+        event_data = post_data.get("event_data", {})
+        is_item_type = todoist_type == "item"
+        is_note_type = todoist_type == "note"
+        new_labels = event_data.get("labels", [])
+        old_labels = (
+            post_data.get("event_data_extra", {}).get("old_item", {}).get("labels", [])
+        )
+        is_updated = todoist_event in ["updated"]
+        is_added = todoist_event in ["added"]
+
+        task_started = "inprogress" in new_labels and "inprogress" not in old_labels
+        task_stopped = "inprogress" not in new_labels and "inprogress" in old_labels
+
+        if is_item_type and is_updated and (task_started or task_stopped):
+            todoist_task = {
+                "todoist_id": event_data.get("id"),
+                "todoist_label_list": event_data.get("labels"),
                 "todoist_type": todoist_type,
                 "todoist_event": todoist_event,
-                "task_started": task_started,
+                "updated_at": event_data.get("updated_at"),
-                "task_stopped": task_stopped,
+                "todoist_project_id": event_data.get("project_id"),
-                "new_labels": new_labels,
+                "description": event_data.get("content"),
-                "old_labels": old_labels,
+                "details": event_data.get("description"),
-            },
+            }
+        if is_note_type and is_added:
+            task_data = event_data.get("item", {})
+            todoist_note = {
+                "task_id": event_data.get("item_id"),
+                "todoist_id": event_data.get("id"),
+                "todoist_label_list": task_data.get("labels"),
+                "todoist_type": todoist_type,
+                "todoist_event": todoist_event,
+                "updated_at": task_data.get("updated_at"),
+                "details": task_data.get("description"),
+                "notes": event_data.get("content"),
+                "is_deleted": (
+                    True if event_data.get("is_deleted") == "true" else False
+                ),
+            }
+
+        if (is_added and not todoist_note) or (is_updated and not todoist_task):
+            self.logger.info(
+                "[todoist_webhook] ignoring wrong todoist type, event or labels",
+                extra={
+                    "todoist_type": todoist_type,
+                    "todoist_event": todoist_event,
+                    "task_started": task_started,
+                    "task_stopped": task_stopped,
+                    "new_labels": new_labels,
+                    "old_labels": old_labels,
+                },
+            )
+            return Response({}, status=status.HTTP_304_NOT_MODIFIED)
+
+        scrobble = None
+        if todoist_task:
+            scrobble = todoist_scrobble_task(
+                todoist_task,
+                user_profile.user_id,
+                stopped=task_stopped,
+                user_context_list=user_profile.task_context_tags,
+            )
+
+        if todoist_note:
+            scrobble = todoist_scrobble_update_task(todoist_note, user_profile.user_id)
+
+        if not scrobble:
+            self.logger.info(
+                "[todoist_webhook] finished with no note or task found",
+                extra={"scrobble_id": None},
+            )
+            return Response(
+                {"error": "No scrobble found to be updated"},
+                status=status.HTTP_304_NOT_MODIFIED,
+            )
+
+        self.logger.info(
+            "[todoist_webhook] finished",
+            extra={"scrobble_id": scrobble.id},
         )
-        return Response({}, status=status.HTTP_304_NOT_MODIFIED)
+        return Response({"scrobble_id": scrobble.id}, status=status.HTTP_200_OK)
-
-    user_profile = UserProfile.objects.filter(
-        todoist_user_id=post_data.get("user_id", None)
-    ).first()
-
-    scrobble = None
-    if todoist_task:
-        scrobble = todoist_scrobble_task(
-            todoist_task,
-            user_profile.user_id,
-            stopped=task_stopped,
-            user_context_list=user_profile.task_context_tags,
-        )
-
-    if todoist_note:
-        scrobble = todoist_scrobble_update_task(todoist_note, user_profile.user_id)
-
-    if not scrobble:
-        logger.info(
-            "[todoist_webhook] finished with no note or task found",
-            extra={"scrobble_id": None},
-        )
-        return Response(
-            {"error": "No scrobble found to be updated"},
-            status=status.HTTP_304_NOT_MODIFIED,
-        )
-
-    logger.info(
-        "[todoist_webhook] finished",
-        extra={"scrobble_id": scrobble.id},
-    )
-    return Response({"scrobble_id": scrobble.id}, status=status.HTTP_200_OK)
 
 
 class EmacsWebhookView(APIView):

vrobbler/templates/profiles/settings_form.html

@@ -138,4 +138,15 @@
     {% endfor %}
     <input type="submit" value="Save">
 </form>
+
+<div class="widget-links" style="margin-top: 16px;">
+    <strong>Todoist Integration:</strong>
+    {% if profile.todoist_auth_key %}
+        <p>Connected to Todoist</p>
+        <a href="{% url 'tasks:task_todoist_auth' %}" class="btn btn-sm btn-secondary">Reconnect to Todoist</a>
+    {% else %}
+        <p>Not connected</p>
+        <a href="{% url 'tasks:task_todoist_auth' %}" class="btn btn-sm btn-primary">Connect to Todoist</a>
+    {% endif %}
+</div>
 {% endblock %}